Fix missing tee to check on warnings #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously tee produced a ${output_file}.linked.bc.out which is used to check and fail on warnings. However after removal of llvm-link step, we missed this out file. It is needed for line 70 check.
pfultz2
reviewed
Jul 22, 2020
| @@ -64,7 +64,7 @@ ${CLANG} -c -emit-llvm \ | |||
| -Xclang -cl-ext=+cl_khr_fp64,+cl_khr_global_int32_base_atomics,+cl_khr_global_int32_extended_atomics,+cl_khr_local_int32_base_atomics,+cl_khr_local_int32_extended_atomics,+cl_khr_int64_base_atomics,+cl_khr_int64_extended_atomics,+cl_khr_3d_image_writes,+cl_khr_byte_addressable_store,+cl_khr_gl_sharing,+cl_amd_media_ops,+cl_amd_media_ops2,+cl_khr_subgroups \ | |||
| -include ${OPENCL_INCLUDE}/opencl-c.h \ | |||
| ${BITCODE_ARGS} \ | |||
| ${options} -o ${output_file}.linked.bc ${input_file} | |||
| ${options} -o ${output_file}.linked.bc ${input_file} |& tee ${output_file}.linked.bc.out | |||
There was a problem hiding this comment.
Will this include compiler warnings? Previously, this was grepping the warnings during the link stage only.
There was a problem hiding this comment.
I removed the grep completely in PR #27.
There was a problem hiding this comment.
Yes this would include all warnings including compiler warnings during the optimization and codegen phases. It won't be checking just link stage.
There was a problem hiding this comment.
I removed the
grepcompletely in PR #27.
Okay, maybe that is the better approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously tee produced a ${output_file}.linked.bc.out which is used to check and fail on warnings. However after removal of llvm-link step, we missed this out file. It is needed for line 70 check.